DBZ-5917 Fix querying column metadata for tables with back slash in t… #4206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpechane
reviewed
Jan 18, 2023
| @@ -1223,11 +1224,23 @@ protected String resolveCatalogName(String catalogName) { | |||
| return catalogName; | |||
| } | |||
|
|
|||
| protected static CharSequence getEscapeSequence() { | |||
There was a problem hiding this comment.
@vjuranek Is not this a bit overkill? Cant' we just use String constant DEFAULT_ESCAPE_CHAR?
There was a problem hiding this comment.
It's here for the purpose we can override it in DB specific sub-classes if there is any other escape char. But given that \ is SQL standard, it's questionable if we will ever needed to use it. So yes, let's use simple approach and add possibility to override it when we really need it.
…he name If the table contains back slash, which is ANSI SQL escape chracter, in its name, querying column metadata would fail in some cases (*) which would result into NPE. Fix table name before the query and escape escape character if the table name contains it. Default backslash works for all currently supported databases as it's ANSI SQL standard, (*) everything works when we collect column metadata for all tables, i.e. when there are no excluded tables
|
Test failures are not related. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…he name
If the table contains back slash, which is ANSI SQL escape chracter, in its name, querying column metadata would fail in some cases (*) which would result into NPE. Fix table name before the query and escape escape character if the table name contains it.
Default backslash works for all currently supported databases as it's ANSI SQL standard, but in case of need it escape methods can be overridded respective subclasses.
(*) everything works when we collect column metadata for all tables, i.e. when there are no excluded tables
https://issues.redhat.com/browse/DBZ-5917