DBZ-594 Stop copy threads after initial sync is completed #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -296,6 +296,7 @@ protected boolean performInitialSync() { | |||
| Thread.interrupted(); | |||
| aborted.set(true); | |||
| } | |||
| this.copyThreads.shutdown(); | |||
There was a problem hiding this comment.
This won't wait for the tasks to complete (see its JavaDoc). A call to awaitTermination() is in order.
There was a problem hiding this comment.
IMHO it will work
- see the
latch.await(), thw shutdown is call only after all taskas are completed - even if the task is in progress it will send a signal and tasks in progress will be completed
- we do not need to block until threads are finished, this can be done asynchronously
There was a problem hiding this comment.
True that, I missed the latch.
|
Rebased and applied. Thanks, @jpechane! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/DBZ-594