DBZ-6225 Treat BOOLEAN as TINYINT(1) consistently #4371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The snapshot phase uses the JDBC driver metadata to resolve the column mappings; however during streaming if a CREATE TABLE ddl statement is used, the column mapping is based on that of the DDL, which was not treating a BOOLEAN column as TINYINT(1); instead it treated the column as BOOLEAN, which is incorrect for MySQL.
|
About the test changes let's take the test method The test changes effectively mirror what we expect in the table and mirror what we ultimately would be emitted as part of the change event since BOOLEAN is technically a synonym for TINYINT(1), which isn't necessarily 0/1 or false/true. |
1 task
|
Superseded by referenced PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/DBZ-6225
The snapshot phase uses the JDBC driver metadata to resolve the column mappings; however, during streaming, if a CREATE TABLE ddl statement is used, the column mapping is based on that of the DDL, which was not treating a BOOLEAN column as TINYINT(1); instead, it treated the column as BOOLEAN, which is incorrect for MySQL.