DBZ-6271 allow binlog to be absent when doing a snapshot only #4418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfvitale
reviewed
Mar 31, 2023
...onnector-mysql/src/main/java/io/debezium/connector/mysql/MySqlSnapshotChangeEventSource.java
Show resolved
Hide resolved
jpechane
added
the
needs more thinking
|
Let's discuss at https://issues.redhat.com/browse/DBZ-6271 |
Thanks for having a look Jiri! I reverted to the original state of the PR which allows for quiet failure of fetching the bin log position. |
|
Let's not use theat quiet :-). Please use {{WARN}} level together with stactrace. |
Made the required change - changed to using WARN. Not sure about the intention of showing the stack trace as we don't need to throw an exception here, but I can re-work it to include a fake try-catch loop if needed. Thanks for reviewing promptly! |
|
@alwaysbemark Applied, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/DBZ-6271
If we're in the initial_only mode of the snapshotter and don't require streaming CDC, we don't need the bin log position to be retrieved and can safely skip it and start the snapshot from scratch.