Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBZ-6361 KafkaSignalThread#SIGNAL_POLL_TIMEOUT_MS option duplicate signal prefix #4471

Merged
merged 1 commit into from Apr 19, 2023

Conversation

MyLanPangzi
Copy link
Contributor

@MyLanPangzi MyLanPangzi commented Apr 19, 2023

https://issues.redhat.com/browse/DBZ-6361

KafkaSignalThread#SIGNAL_POLL_TIMEOUT_MS option duplicate signal prefix. need remove one.

@github-actions
Copy link

Welcome as a new contributor to Debezium, @MyLanPangzi. Reviewers, please add missing author name(s) and alias name(s) to the COPYRIGHT.txt and Aliases.txt respectively.

@github-actions
Copy link

Hi @MyLanPangzi, thanks for your contribution. Please prefix the commit message(s) with the DBZ-xxx JIRA issue key.

@MyLanPangzi MyLanPangzi changed the title remove superfluous signal DBZ-6361 KafkaSignalThread config superfluous signal Apr 19, 2023
@mfvitale
Copy link
Member

Hi @MyLanPangzi thanks for your contribution, please:

For any other information about contributing please refer to Contributing to Debezium

@rk3rn3r
Copy link
Member

rk3rn3r commented Apr 19, 2023

I can imagine that the signal. prefix was meant for not colliding with config properties from Kafka itself maybe and kind of group options that belong to signalling together when you for example order properties lexically? @jpechane

@vjuranek
Copy link
Member

@rk3rn3r signal prefix is still there, the issue is that it's there twice, i.e. now it's signal.signal.kafka.poll.timeout.ms

@mfvitale
Copy link
Member

I can imagine that the signal. prefix was meant for not colliding with config properties from Kafka itself maybe and kind of group options that belong to signalling together when you for example order properties lexically? @jpechane

CONFIGURATION_FIELD_PREFIX_STRING is already the 'signal' prefix. So i think in this case is a mistake.

@rk3rn3r
Copy link
Member

rk3rn3r commented Apr 19, 2023

Ah, sorry. I didn't see this from the PR code. My bad.

@MyLanPangzi MyLanPangzi changed the title DBZ-6361 KafkaSignalThread config superfluous signal DBZ-6361 KafkaSignalThread#SIGNAL_POLL_TIMEOUT_MS option duplicate signal prefix Apr 19, 2023
@jpechane jpechane merged commit f07ec7a into debezium:main Apr 19, 2023
3 checks passed
@jpechane
Copy link
Contributor

@MyLanPangzi Applied, thanks!

@jpechane
Copy link
Contributor

@MyLanPangzi Could you please share your name so we can add it to the copyright list? Thanks!

@MyLanPangzi
Copy link
Contributor Author

@jpechane oh. sorry. I'm busy these days. My name is bo.xie. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants