Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBZ-6368 Align version of Antlr runtime #4481

Merged
merged 1 commit into from Apr 21, 2023

Conversation

slknijnenburg
Copy link
Contributor

Ensure all modules use antlr-runtime version 4.10.1. There is a breaking change in Antlr 4.10 that makes parsers from older versions incompatible.

Link: https://issues.redhat.com/browse/DBZ-6368

Ensure all modules use antlr-runtime version 4.10.1. There
is a breaking change in antlr 4.10 that makes schemas from
older versions incompatible.
@github-actions
Copy link

Welcome as a new contributor to Debezium, @slknijnenburg. Reviewers, please add missing author name(s) and alias name(s) to the COPYRIGHT.txt and Aliases.txt respectively.

@github-actions
Copy link

Hi @slknijnenburg, thanks for your contribution. Please prefix the commit message(s) with the DBZ-xxx JIRA issue key.

@Naros
Copy link
Member

Naros commented Apr 20, 2023

Hi, @slknijnenburg I believe this is already in Debezium 2.2, released today. Is there a need to backport this to 2.1 since we likely won't be making many major changes to 2.1 moving forward?

@slknijnenburg
Copy link
Contributor Author

slknijnenburg commented Apr 20, 2023

Hi, @slknijnenburg I believe this is already in Debezium 2.2, released today. Is there a need to backport this to 2.1 since we likely won't be making many major changes to 2.1 moving forward?

@Naros I wasn't aware 2.2 final was coming out so soon, that's good news :) For us it's no problem to upgrade as we're still in POC phase, but if people for any reason need to stay on 2.1.X it might still be worthwhile to merge as the MySQLConnector is broken on 2.1.3/2.1.4 when used in debezium-server.

I'll leave that decision to you, we can move forward either way 👍

@jpechane jpechane merged commit 2627b1c into debezium:2.1 Apr 21, 2023
17 of 24 checks passed
@jpechane
Copy link
Contributor

@slknijnenburg Thanks for the PR. I merged it. Albeit we don't plan to do another 2.1.x release it is still worthy for those whou'd build it from source.

@slknijnenburg slknijnenburg deleted the DBZ-6368 branch April 21, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants