Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DBZ 6408 Add docs on how to extend channels and notification #4538

Merged
merged 4 commits into from May 30, 2023
Merged

DBZ 6408 Add docs on how to extend channels and notification #4538

merged 4 commits into from May 30, 2023

Conversation

mfvitale
Copy link
Member

@mfvitale mfvitale requested a review from roldanbob May 11, 2023 09:27
@mfvitale
Copy link
Member Author

@roldanbob let me know if you need details on this

roldanbob
roldanbob requested changes May 25, 2023
View reviewed changes
Copy link
Contributor

@roldanbob roldanbob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, @mfvitale, you did a ton of work here. Thanks for all of the effort.

I did a thorough review and did my best to ensure consistency across similar sections. I'm sure that some of my suggestions actually modify pre-existing content, including some that I previously authored, but that I now think should be reworded.
I might have missed a few things, but after you incorporate suggestions, perhaps I can make another pass to see if anything slipped through the cracks. Thanks.

documentation/modules/ROOT/pages/configuration/notification.adoc Outdated Show resolved Hide resolved
documentation/modules/ROOT/pages/configuration/notification.adoc Outdated Show resolved Hide resolved
documentation/modules/ROOT/pages/configuration/notification.adoc Outdated Show resolved Hide resolved
documentation/modules/ROOT/pages/configuration/notification.adoc Outdated Show resolved Hide resolved
documentation/modules/ROOT/pages/configuration/notification.adoc Outdated Show resolved Hide resolved
...ules/ROOT/partials/modules/all-connectors/proc-triggering-an-incremental-snapshot-kafka.adoc Outdated Show resolved Hide resolved
...ules/ROOT/partials/modules/all-connectors/proc-triggering-an-incremental-snapshot-nosql.adoc Outdated Show resolved Hide resolved
...odules/ROOT/partials/modules/all-connectors/proc-triggering-an-incremental-snapshot-sql.adoc Outdated Show resolved Hide resolved
...on/modules/ROOT/partials/modules/all-connectors/proc-triggering-an-incremental-snapshot.adoc Show resolved Hide resolved
...on/modules/ROOT/partials/modules/all-connectors/proc-triggering-an-incremental-snapshot.adoc Outdated Show resolved Hide resolved
@github-actions
Copy link

Hi @mfvitale, thanks for your contribution. Please prefix the commit message(s) with the DBZ-xxx JIRA issue key.

3 similar comments
@github-actions
Copy link

Hi @mfvitale, thanks for your contribution. Please prefix the commit message(s) with the DBZ-xxx JIRA issue key.

@github-actions
Copy link

Hi @mfvitale, thanks for your contribution. Please prefix the commit message(s) with the DBZ-xxx JIRA issue key.

@github-actions
Copy link

Hi @mfvitale, thanks for your contribution. Please prefix the commit message(s) with the DBZ-xxx JIRA issue key.

@mfvitale @roldanbob
DBZ-6408 Improve documentation for notifications and signaling
3af66c6 
Apply suggestions from code review

Co-authored-by: roldanbob <broldan@redhat.com>

Apply suggestions from code review

Co-authored-by: roldanbob <broldan@redhat.com>

Apply suggestions from code review

Co-authored-by: roldanbob <broldan@redhat.com>

Apply suggestions from code review

Co-authored-by: roldanbob <broldan@redhat.com>
roldanbob
roldanbob requested changes May 26, 2023
View reviewed changes
Copy link
Contributor

@roldanbob roldanbob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mfvitale Just a few more minor suggestions. I took the liberty of converting the list of tasks for using custom channels into unordered lists and linked each step to the appropriate topic.

documentation/modules/ROOT/pages/configuration/notification.adoc Outdated Show resolved Hide resolved
documentation/modules/ROOT/pages/configuration/notification.adoc Outdated Show resolved Hide resolved
documentation/modules/ROOT/pages/configuration/notification.adoc Outdated Show resolved Hide resolved
documentation/modules/ROOT/pages/configuration/notification.adoc Outdated Show resolved Hide resolved
documentation/modules/ROOT/pages/configuration/signalling.adoc Outdated Show resolved Hide resolved
documentation/modules/ROOT/pages/configuration/signalling.adoc Outdated Show resolved Hide resolved
documentation/modules/ROOT/pages/configuration/signalling.adoc Outdated Show resolved Hide resolved
documentation/modules/ROOT/pages/configuration/signalling.adoc Outdated Show resolved Hide resolved
@mfvitale @roldanbob
DBZ-6408 Improve documentation for notifications and signaling
5e48b4e 
Co-authored-by: roldanbob <broldan@redhat.com>
@mfvitale
Copy link
Member Author

mfvitale commented May 29, 2023 •
edited

@roldanbob your suggestions addressed. Do you think we are now in a good point?

@roldanbob
Copy link
Contributor

@roldanbob your suggestions addressed. Do you think we are now in a good point?

Yes, @mfvitale, I think you're good to go now! Thanks for your patience!

@jpechane jpechane merged commit ed44f25 into debezium:main May 30, 2023
27 of 28 checks passed
@jpechane
Copy link
Contributor

@mfvitale @roldanbob Applied, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roldanbob roldanbob roldanbob requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mfvitale @roldanbob @jpechane