Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DBZ-6676 Oracle XML/RAW documentation updates #4681

Merged
merged 1 commit into from
Jul 19, 2023
Merged

DBZ-6676 Oracle XML/RAW documentation updates #4681

merged 1 commit into from
Jul 19, 2023

Conversation

Naros
Copy link
Member

@Naros Naros commented Jul 17, 2023

https://issues.redhat.com/browse/DBZ-6676

@roldanbob This is a follow-up from DBZ-3605 (PR #4615).

@Naros
Copy link
Member Author

Naros commented Jul 17, 2023 •
edited

@roldanbob I addressed everything but this one discussion referenced here: #4615 (comment)

@Naros Naros requested a review from roldanbob July 17, 2023 18:12
roldanbob
roldanbob approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@roldanbob roldanbob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @Naros. I started to correct base64 => Base64, but I think that in the context it's correct to use lc. Other than that, I think that this is GTG. Thanks!

@Naros Naros added the 2.4 label Jul 17, 2023
@Naros Naros merged commit 0b0c5d8 into debezium:main Jul 19, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roldanbob roldanbob roldanbob approved these changes

Assignees
No one assigned
Labels
2.4
Projects
None yet
Milestone
No milestone
2 participants
@Naros @roldanbob