Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor EmbeddedEngine::run method #4696

Merged
merged 6 commits into from
Aug 4, 2023
Merged

Refactor EmbeddedEngine::run method #4696

merged 6 commits into from
Aug 4, 2023

Conversation

vjuranek
Copy link
Member

jpechane
jpechane approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@jpechane jpechane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vjuranek Nice job! Could you take it one more step further and extract the poll logic into a separate method too so the run will be mostly flow of methods/states?

Feel free to merge it yourself after that.

@vjuranek vjuranek merged commit 230c056 into debezium:main Aug 4, 2023
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpechane jpechane jpechane approved these changes

@mfvitale mfvitale mfvitale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@vjuranek @jpechane @mfvitale