-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DBZ-6786 Use custom row deserializers in case of binlog compression #4759
Conversation
Welcome as a new contributor to Debezium, @rolevinks. Reviewers, please add missing author name(s) and alias name(s) to the COPYRIGHT.txt and Aliases.txt respectively. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rolevinks Thanks, the solution LGTM! Unfortunately we need to test it as well.
Would it be possible to
- Create a test that fails with disable binlog compession
- Create a special annotation and rule to mark that test so it is executed only under condition
- Add a new profile to run test for enabled compression with MySQL compression enabled container
- Add that execution to
assembly
profile
That way we'd be able to verify the code works and make it part of our regular CI.
Hi @jpechane There already is a test that uses binlog compression, the Please let me know if this is enough as far as testing goes. |
@rolevinks According to the Jira the issue is visible for UUID, so maybe adding a UUID column to the test would revela the problem? |
@jpechane Yes, that's what I did. I added a |
So, if the test is used on non-fixed branch and run against compression enabled MySQL then wil it fail? |
That is correct. |
@rolevinks Applied, thanks! |
No description provided.