DBZ-6839 Fix PostgresConnectorIT#shouldAddNewFieldToSourceInfo #4807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PostgresConnectorIT#shouldAddNewFieldToSourceInfo fails only when run together with other tests and the failure is random. It seem there is a caching issue in Apicuro, when `test_server.s1.a-value` artifact references `io.debezium.connector.postgresql.Source` version 1, which hasnt't `newField` field and this reference is used also in `shouldAddNewFieldToSourceInfo` where artifact with version 2 should be used. Using dedicated table and thus creating new artifact in Apucurio should fix this issue. Also remove unused variable from `CustomPostgresSourceInfoStructMaker`.
obabec
approved these changes
Aug 24, 2023
|
@vjuranek Applied, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PostgresConnectorIT#shouldAddNewFieldToSourceInfo fails only when run together with other tests and the failure is random. It seem there is a caching issue in Apicuro, when
test_server.s1.a-valueartifact referencesio.debezium.connector.postgresql.Sourceversion 1, which hasnt'tnewFieldfield and this reference is used also inshouldAddNewFieldToSourceInfowhere artifact with version 2 should be used. Using dedicated table and thus creating new artifact in Apucurio should fix this issue.Also remove unused variable from
CustomPostgresSourceInfoStructMaker.https://issues.redhat.com/browse/DBZ-6839