DBZ-6841 Fix randomly failing BaseSourceTaskTest#verifyTaskRestartsSuccessfully #4808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ccessfully Test was passing locally and in the CI as the start was very fast and after the first start retriable wait condition wasn't met, so we actually sleep and while the sleep we doesn't increment the counter and the state is still `RESTARTING`. On slower machines when start takes longer time and we don't wait, the test is actualy wrong. The correct test either should remove last assert for `RESTARTING` state or increase number of failures and add a sleep time after initial start, so that there is no retry wait time. This PR implements the later option.
rk3rn3r
changed the title
|
/packit test --labels mongodb |
|
Thx a lot for the quick evaluation of the root cause and the quick fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test was passing locally and in the CI as the start was very fast and after the first start retriable wait condition wasn't met, so we actually sleep and while the sleep we doesn't increment the counter and the state is still
RESTARTING. On slower machines when start takes longer time and we don't wait, the test is actualy wrong. The correct test either should remove last assert forRESTARTINGstate or increase number of failures and add a sleep time after initial start, so that there is no retry wait time.This PR implements the later option.
https://issues.redhat.com/browse/DBZ-6841