DBZ-6895 Fix OpenLogReplicator confirmation #4859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/packit test --labels oracle |
|
Hi @jpechane I've run the tests for OLR locally, I've kicked off the XStream and LogMiner ones via the testing farm. I believe this is ready barring your review as long as XStream and LogMiner pass CI. |
|
Looks like a testing farm problem, I'll kick the tests off locally and let them run over-night instead. |
|
@Naros LGTM, but did not we say that we will emit forcefully heartbeat message when a checkpoint event is received? |
We did and I completely forgot. I'll add that and double-check that it doesn't create any problems with the tests. |
|
@Naros Applied, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/DBZ-6895