DBZ-7071 Introduce internal schema change exclusion option #4961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new internal `log.mining.schema_changes.username.exclude.list` to allow users to customize the default behavior for excluding the SYS and SYSTEM usernames from DDL changes.
|
/packit test --labels oracle |
|
Failures are unrelated to the change (added as part of DBZ-7072). |
jpechane
reviewed
Oct 25, 2023
| @@ -781,6 +791,7 @@ public OracleConnectorConfig(Configuration config) { | |||
| this.logMiningRestartConnection = config.getBoolean(LOG_MINING_RESTART_CONNECTION); | |||
| this.logMiningMaxScnDeviation = Duration.ofMillis(config.getLong(LOG_MINING_MAX_SCN_DEVIATION_MS)); | |||
| this.logMiningInifispanGlobalConfiguration = config.getString(LOG_MINING_BUFFER_INFINISPAN_CACHE_GLOBAL); | |||
| this.logMiningSchemaChangesUsernameExcludes = Strings.setOf(config.getString(LOG_MINING_SCHEMA_CHANGES_USERNAME_EXCLUDE_LIST), String::new); | |||
There was a problem hiding this comment.
I am going to keep it here as it is the same as in other case of the class but IMHO Function.identity() would better reflect the meaning.
|
@Naros Applied, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/DBZ-7071
Add a new internal
log.mining.schema_changes.username.exclude.listto allow users to customize the default behavior for excluding the SYS and SYSTEM usernames from DDL changes.