Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DBZ-7218 Clarify Oracle log destination requirements #5085

Merged
merged 3 commits into from
Dec 11, 2023
Merged

DBZ-7218 Clarify Oracle log destination requirements #5085

merged 3 commits into from
Dec 11, 2023

Conversation

Naros
Copy link
Member

@Naros Naros commented Dec 7, 2023

@Naros Naros added the 2.5 label Dec 7, 2023
@Naros Naros requested a review from roldanbob December 7, 2023 10:35
jpechane
jpechane approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@jpechane jpechane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Naros LGTM, thanks! Feel free to merge if docs is ok.

roldanbob
roldanbob requested changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@roldanbob roldanbob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you go @Naros.

I went ahead and added the Nebel annotations (L2245-2247). Please omit them if they aren't needed.

documentation/modules/ROOT/pages/connectors/oracle.adoc Outdated Show resolved Hide resolved
documentation/modules/ROOT/pages/connectors/oracle.adoc Outdated Show resolved Hide resolved
documentation/modules/ROOT/pages/connectors/oracle.adoc Outdated Show resolved Hide resolved
documentation/modules/ROOT/pages/connectors/oracle.adoc Outdated Show resolved Hide resolved
documentation/modules/ROOT/pages/connectors/oracle.adoc Outdated Show resolved Hide resolved
documentation/modules/ROOT/pages/connectors/oracle.adoc Outdated Show resolved Hide resolved
documentation/modules/ROOT/pages/connectors/oracle.adoc Show resolved Hide resolved
@Naros Naros merged commit 6334557 into debezium:main Dec 11, 2023
26 checks passed
@Naros
Copy link
Member Author

Naros commented Dec 11, 2023

Thanks for the review @jpechane and @roldanbob .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roldanbob roldanbob roldanbob requested changes

@jpechane jpechane jpechane approved these changes

Assignees
No one assigned
Labels
2.5
Projects
None yet
Milestone
No milestone
3 participants
@Naros @jpechane @roldanbob