Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DBZ-7257 Fix regression in parsin Oracle 12 version #5102

Merged
merged 2 commits into from
Dec 19, 2023
Merged

DBZ-7257 Fix regression in parsin Oracle 12 version #5102

merged 2 commits into from
Dec 19, 2023

Conversation

vjuranek
Copy link
Member

@Naros
Copy link
Member

Naros commented Dec 14, 2023

/packit test --labels oracle

Naros
Naros approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@Naros Naros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for adding the tests, I should have probably done that long ago and that likely would have avoided this issue all together, kudos 🎉 .

Feel free to merge if the test suite doesn't fail related to these changes.

@vjuranek
Copy link
Member Author

/packit test --labels oracle

@vjuranek vjuranek marked this pull request as draft December 14, 2023 20:03
@vjuranek
Copy link
Member Author

/packit test --labels oracle

@vjuranek vjuranek marked this pull request as ready for review December 15, 2023 15:54
@vjuranek
Copy link
Member Author

Waiting for test farm to be more stable to re-run the tests.

@jpechane
Copy link
Contributor

/packit test --labels oracle

@vjuranek
Copy link
Member Author

@jpechane Oracle testsuite is currently broken, the fix is in PR #5113 and PR #5114. This one should be re-run after merging these PRs.

@jpechane
Copy link
Contributor

/packit test --labels oracle

@jpechane
Copy link
Contributor

@vjuranek Merged and re-running

@vjuranek vjuranek merged commit 6768766 into debezium:main Dec 19, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Naros Naros Naros approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@vjuranek @Naros @jpechane