Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBZ-7446 Reduce string creation during SQL_REDO column read #5230

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

jchipmunk
Copy link
Member

Oracle Connector can create a new string when reading SQL_REDO column only if CSF column value is 1.

https://issues.redhat.com/browse/DBZ-7446

Oracle Connector can create a new string when reading SQL_REDO column only if CSF column value is 1.
Copy link
Member

@Naros Naros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's just wait on CI. Thanks @jchipmunk

@Naros
Copy link
Member

Naros commented Feb 4, 2024

/packit test --labels oracle

@Naros Naros self-requested a review February 4, 2024 16:14
Copy link
Member

@Naros Naros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually appears to be some test failures :(

@Naros
Copy link
Member

Naros commented Feb 5, 2024

/packit test --labels oracle

@Naros
Copy link
Member

Naros commented Feb 5, 2024

Test failure is unrelated.

@Naros Naros merged commit c669857 into debezium:main Feb 5, 2024
29 of 30 checks passed
@jchipmunk jchipmunk deleted the DBZ-7446 branch February 5, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants