Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DBZ-6236 Reset ErrorHandler retry counter on successful poll #5275

Merged
merged 2 commits into from Feb 22, 2024
Merged

DBZ-6236 Reset ErrorHandler retry counter on successful poll #5275

merged 2 commits into from Feb 22, 2024

Conversation

Naros
Copy link
Member

@Naros Naros commented Feb 16, 2024

@Naros Naros requested a review from jpechane February 16, 2024 14:37
@jpechane
Copy link
Contributor

@Naros The test failures are related to the change.

jpechane
jpechane approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@jpechane jpechane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Naros LGTM, thanks! Please feel free to merge yourself when CI is finished.

@Naros
Copy link
Member Author

Naros commented Feb 21, 2024

Test failures:
MariaDB - Unrelated
PostgeSQL - Unrelated, failures fixed in other PRs
SQL Server - Needs a re-run, may or may not be related
Db2 - Unrelated, failures fixed in Db2
Informix - Unrelated

@Naros
Copy link
Member Author

Naros commented Feb 22, 2024

Going to rebase against main once more and test out @mfvitale fix for #5310 as I seem to hit this problem repeatedly.

@Naros Naros merged commit 4c15d2b into debezium:main Feb 22, 2024
35 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpechane jpechane jpechane approved these changes

Assignees
No one assigned
Labels
2.5 2.6
Projects
None yet
Milestone
No milestone
2 participants
@Naros @jpechane