Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBZ-7389 Oracle log collector with full RAC support #5398

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

Naros
Copy link
Member

@Naros Naros commented Mar 17, 2024

@Naros Naros added the 2.6 label Mar 17, 2024
@Naros
Copy link
Member Author

Naros commented Mar 17, 2024

/packit test --labels oracle

@Naros
Copy link
Member Author

Naros commented Mar 17, 2024

/packit test --identifier oracle-21
/packit test --identifier oracle-21-xs

@Naros
Copy link
Member Author

Naros commented Mar 17, 2024

@jpechane, so I left the overall error-throwing bit the same in the rework here and littered it with a ton of debug logging, but I am considering having the underlying sanity check functions throw exceptions rather than returning true/false.

This would allow us to bubble up from the sanity checks a more concrete root cause to the top-level exception, giving users immediate feedback on the underlying error reason in the event they do not have DEBUG logging enabled. Otherwise, I think the solution is solid from my PoV; but I did ping Lucas on the Jira to give it a review & check.

@jpechane
Copy link
Contributor

@Naros Do we need to throw an exception? Maybe we can create and log an exception as part of the checking to get the stacktrace in the log?

@Naros
Copy link
Member Author

Naros commented Mar 18, 2024

@Naros Do we need to throw an exception? Maybe we can create and log an exception as part of the checking to get the stacktrace in the log?

I actually think that idea is much cleaner and avoids unnecessarily over-complicating the caller methods where the loop logic is so it remains quite clean 👍

@Naros Naros requested a review from jpechane March 18, 2024 15:07
@Naros
Copy link
Member Author

Naros commented Mar 18, 2024

/packit test --identifier oracle-21

@jpechane jpechane merged commit 9f6a26b into debezium:main Mar 19, 2024
25 checks passed
@jpechane
Copy link
Contributor

@Naros Applie, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants