DBZ-627 Unifying TopicSelector implementations #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunnarmorling
force-pushed
the
topicselector
branch
from
7218382
to
e556aa6
Compare
|
@gunnarmorling Why was MongoDB connector ommitted? |
|
Ah, good spot. I missed it because MongoDB's selector doesn't extend the
existing TopicSelector interface from core. I'll add that, too. Thanks!
|
gunnarmorling
force-pushed
the
topicselector
branch
from
e556aa6
to
32e4b1c
Compare
|
@jpechane pushed one more commit to cover MongoDB, too. |
jpechane
reviewed
Jul 18, 2018
| * @return the topic selector; never null | ||
| */ | ||
| private static String getTopicName(CollectionId collectionId, String prefix, String delimiter) { | ||
| StringJoiner sb = new StringJoiner(delimiter); |
There was a problem hiding this comment.
@gunnarmorling Is this really needed? Is prefix really optional?
|
It was like that before and I tried to leave the actual implementation
unchanged.
|
|
@gunnarmorling Applied, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/DBZ-627
I'll send the corresponding Oracle connector change tomorrow. I've decided to do this now in order to simplify a heartbeat implementation for PG and the others subsequently.