DBZ-1081 Fallback to restart_lsn in pg 9.5 #728
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@addisonj I think that's a reasonable suggestion, thanks! I've added one minor style-related comment inline, otherwise it LGTM. Could you also prepare an update for the connector doc page, updating the info on the supported minimum version and the implication of using this with 9.5? Thanks!
@jpechane, any comments from your side?
...r-postgres/src/main/java/io/debezium/connector/postgresql/connection/PostgresConnection.java
Outdated
Show resolved
Hide resolved
|
@gunnarmorling I think we are good to go! |
|
Cool, thanks for confirming. I'll merge it than as soon as the style issue has been sorted out. |
In pg 9.5, confirmed_flush_lsn is not availiable. However, there is restart_lsn, which should be safe to use with a downside of producing some extra duplicate records. This page: https://paquier.xyz/postgresql-2/postgres-9-6-feature-highlight-replication-slot-improvements/ indicates as such and this allows for DBZ to support PG 9.5
|
fixed, let me know if there is anything else you need on this one! |
|
@jpechane WDYT about adding PG 9.5 to the matrix job? |
|
Rebased and applied. Thanks, @addisonj! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/DBZ-1081
In pg 9.5, confirmed_flush_lsn is not availiable. However, there is
restart_lsn, which should be safe to use with a downside of producing
some extra duplicate records.
This page: https://paquier.xyz/postgresql-2/postgres-9-6-feature-highlight-replication-slot-improvements/
indicates as such and this allows for DBZ to support PG 9.5