New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DBZ-92, DBZ-97 Makes logging more verbose and changes the snapshot reader to produce separate events for each DDL change #84
Conversation
@hchiorean Great! Our team needs it. |
} | ||
logger.info("Recorded the following DDL statements for database '{}':", dbName); | ||
Arrays.stream(ddlStatements.split(";" + System.lineSeparator())).forEach(ddlStatement -> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, sorry for that, I did a duplicated thing https://github.com/DataPipelineInc/debezium/commit/3b9dddb51fd461d4e5b63fd5453d68cecf92cf91
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hchiorean, I know this is what we talked about yesterday, but this splitting on ;
concerns me because if any of the statements were to contain a ;
character, then the split logic would break that one statement into several.
Perhaps an alternative is to not join but instead of one call to schema.applyDdl
with a list on line 295 we call schema.applyDdl
for each of the statements in the list. Or, @mvj3's suggestion doesn't even add the statements to the list but instead calls schema.applyDdl
for each statement as we create them.
Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rhauch Or I just create a PR about this?
This commit https://github.com/DataPipelineInc/debezium/commit/3b9dddb51fd461d4e5b63fd5453d68cecf92cf91 is tests passed in my local machine (via run mvn clean test
with docker support)
amended the commit |
…ader to produce separate events for each DDL change
|
@hchiorean docker: unrecognized service I also meet several docker issues on Travis, but them didn't happen on my local Mac. One of them is https://issues.jboss.org/browse/DBZ-93 [travis] Unable to create data directory /zookeeper/txns/version-2 . It suddenly fixed a few days ago, and I don't know why. But Travis still gives me other docker problems. |
@hchiorean, @mvj3: Travis are having issues at the moment, though at this time they've identified the problem. I'll restart the job when they fully resolve the problems. |
This pull request failed on Travis multiple times with errors like the following after the first build (recall that the build attempts to re-run maven upon an error, and the subsequent failures are different):
This error implies that the In the meantime, @hchiorean perhaps you might try creating a pull request that changes the MongoDB port to something else (e.g., 28017). Unfortunately, it needs to be changed in two places; feel free to set a property to make this easier. |
I'm not sure what's going on, but this builds locally. Since I'm certain that nothing in the PR is broken but instead there's something wrong with the Travis environment, I'm going to merge this anyway. |
Travis-CI support responded, and they've upgraded their images to ensure MongoDB is disabled upon boot. Woot! |
No description provided.