DBZ-686 Allow a custom pg_config to be specified #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@film42 Thanks, verified with postgres image. Could you please just creae a Jira issue a link it to this PR? |
|
Sure thing @jpechane ! I'll create an account and post this as an issue now. |
jpechane
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what pg_repack does to allow the user to specify which version of
pg_configit should use.Example: https://github.com/reorg/pg_repack/blob/master/Makefile#L9
When upgrading postgres versions, it would be nice to automatically build decoderbufs for each db version to avoid accidental breakage. Better safe than sorry.
PS: I'm not sure if you guys would rather me try to get this merged upstream first or not. Just let me know and I'll move this if need be. Thanks!