Simplify memory handling by removing pointless calls to pfree #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oth more efficient and more reliable than individually freeing each allocated object.
|
👍 |
|
Thanks for submitting the change, @DuncanSands, and thanks for the quick review, @hchiorean! One thing only, @DuncanSands, could you file a JIRA issue and refer to it in the commit message? |
|
I've filed https://issues.jboss.org/browse/DBZ-496 and applied this PR. Thanks @DuncanSandsl and sorry for the long delay, this fell a bit through the cracks. |
|
On 11/29/2017 04:30 PM, Gunnar Morling wrote:
I've filed https://issues.jboss.org/browse/DBZ-496 and applied this PR. Thanks
@duncansandsl and sorry for the long delay, this fell a bit through the cracks.
Sorry for not doing it myself, I've been busy with other things.
Ciao, Duncan.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call to MemoryContextReset frees all allocated memory in one fell swoop, so the calls to pfree are totally useless and just complicate the logic. Tested by streaming 100 million rows and observing that memory usage did not increase.