Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

WiP WordPress theme #2

Open
wants to merge 15 commits into from

2 participants

@tomer

No description provided.

@debloper
Owner
  • Please provide little description with the pull-requests, about the introduced features.
  • Use the branch-root instead of ./MozillaCommunityTheme/
    • The entire repository is about Mozilla Community Sites' theme
  • I don't see the use of some image files committed in the code
    • Files such as background.png, footer-background.png are never used in the CSS
    • Please don't commit (yet) unnecessary files
    • If those files will be required in the next step, include them when they are required
  • Hell lotta files in one commit - feels like SVN strategy
    • It's tough for maintaining & tracing the code
    • Please commit step by step, implementing one feature at a time
  • The theme isn't standalone - tell me if I'm wrong about it
    • tomer@f9c427e#L9R13
    • We need standalone theme, not child-theme.
    • Even if it's a child theme (prefer not to) - re-implement it as standalone.
Amiad menu 02c7757
@tomer
@debloper
Owner
  • There will not be more than one theme. Not primarily intended.
  • Even if there are more than one theme and you call this one "MozillaCommunityTheme" - what are you going to call the others?
  • If at that point of time, you give this theme a new name and/or change the directory name - it's technically similar to putting the files into a directory from root in Git's respect.

  • Include the extra files when they are included in the code

  • They may be required in future, but until then, it's not good practice to include them now.
  • Copy over files, that's okay - but don't stage/commit them until required.

  • As of making a child-theme, you're underestimating the MCS project.

  • We're making a theme - for people to make child themes on - if they need.

I suggest, keep it in you repository & let that be the official WP theme of MCS for now. Merging it here will not be required till we have better vision on the theme. If again a new "build-from-scratch" has to start, it'll be a mess in the repo.

Stabilize/complete this theme & let's release Israel & Antarctica site on your theme - we'll figure out by then.

@debloper
Owner

Nice work @amiad - the gradient also looks good-enough.
One thing though, follow @tomer change your tab-width to 4-spaces (it's 2 spaces now) - please maintain this consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Dec 3, 2011
  1. @tomer

    WiP WordPress theme

    tomer authored
Commits on Dec 4, 2011
  1. menu

    Amiad authored
  2. @tomer

    Merge pull request #1 from amiad/wordpress

    tomer authored
    menu
  3. adding logo

    Amiad authored
  4. @tomer

    Merge pull request #2 from amiad/wordpress

    tomer authored
    adding logo
  5. @tomer
  6. search form on menu bar

    Amiad authored
  7. move logo to right for rtl

    Amiad authored
  8. @tomer

    Merge pull request #3 from amiad/wordpress

    tomer authored
    search form on menu bar
Commits on Dec 6, 2011
  1. small header

    Amiad authored
  2. placing search, orderin sidebar

    Amiad authored
  3. @tomer

    Merge pull request #4 from amiad/wordpress

    tomer authored
    header, search and sidebar
  4. @tomer

    Adding box-shadow to sidebars

    tomer authored
  5. @tomer
  6. @tomer
This page is out of date. Refresh to see the latest.
View
BIN  MozillaCommunityTheme/img/background.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
View
BIN  MozillaCommunityTheme/img/divider-main.jpg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
View
BIN  MozillaCommunityTheme/img/footer-background.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
View
BIN  MozillaCommunityTheme/img/home.divider.jpg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
View
BIN  MozillaCommunityTheme/img/mctlogo-small.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
View
BIN  MozillaCommunityTheme/img/mctlogo.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
View
BIN  MozillaCommunityTheme/img/mozilla-logo.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
View
BIN  MozillaCommunityTheme/img/page-background.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
View
21 MozillaCommunityTheme/rtl.css
@@ -0,0 +1,21 @@
+@import url("../twentyeleven/rtl.css");
+
+#branding hgroup {
+ background-position: right;
+}
+#site-title {
+ padding-left: 0;
+ padding-right: 170px;
+}
+#site-description {
+ margin: 0;
+ margin-right: 100px;
+}
+#access ul {
+ padding-right: 1.4%;
+ padding-left: 0;
+}
+#branding #searchform {
+ right: auto;
+ left: 5.6%;
+}
View
BIN  MozillaCommunityTheme/screenshot.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
View
146 MozillaCommunityTheme/style.css
@@ -0,0 +1,146 @@
+/*
+Theme Name: Mozilla Community theme (based on WordPress TwentyEleven)
+Theme URI: https://wiki.mozilla.org/MCS
+Description: Child theme for the Twenty Eleven theme
+Author: Mozilla MCS team
+Author URI: https://wiki.mozilla.org/MCS
+Template: twentyeleven
+Version: 0.1.1-tomer
+*/
+
+
+
+@import url("../twentyeleven/style.css");
+
+#branding a img { display: none } /* TEMPORARY REMOVE BANNER IMAGE */
+
+body {
+ padding: 0;
+ padding-top: 30px;
+ background: url("img/page-background.png") white repeat-x;
+}
+
+#branding { border-top: none; }
+
+/*#branding hgroup { display: inline-block; }*/
+#branding hgroup {
+ background: url("img/mctlogo-small.png");
+ background-repeat: no-repeat;
+ padding-bottom: 10px;
+ margin: 0 4.5%
+}
+#site-title {
+ padding-left: 170px;
+ padding-top: 20px;
+}
+#site-title a { font-size: 40px;}
+#site-description {
+ display: none;
+ margin: 0;
+ font-size: 30px;
+ margin-left: 170px;
+}
+
+#page {
+ background: none;
+ margin: 0;
+ max-width: none;
+}
+
+#main {
+ margin: 2em auto;
+ max-width: 1000px;
+ min-width: 1000px;
+}
+
+#access {
+ background: #2e89ca;
+
+ background-image: -webkit-linear-gradient(top, #2e88c9, #1c5a9a);
+ background-image: -moz-linear-gradient(top, #2e88c9, #1c5a9a);
+ background-image: -ms-linear-gradient(top, #2e88c9, #1c5a9a);
+ background-image: -o-linear-gradient(top, #2e88c9, #1c5a9a);
+ background-image: linear-gradient(top, #2e88c9, #1c5a9a);
+
+ border-radius: 5px;
+/* box-shadow: none;*/
+ width: 90%;
+ margin-left: 5%;
+ margin-right: 5%;
+}
+#access div.menu {
+ margin-left: 1%;
+ margin-right: 1%;
+}
+#access ul {
+ padding-left: 1.4%;
+}
+#access a {
+ font-size: 14px;
+}
+
+#branding #searchform {
+ top: 5.1em;
+ right: 5.6%;
+}
+#branding #s, #branding #s:focus {
+ width: 73%;
+ background-color: #f9f9f9;
+ border-radius: 5px;
+}
+#colophon {
+ background: repeat scroll 0 0 #33559B !important;
+ color: lightgray;
+}
+
+.widget input:focus { background: white; }
+
+html { background: #33559B; }
+
+#colophon .widget-title {
+ color: white;
+ font-weight: bold;
+}
+
+#supplementary, #site-generator {
+ border-top: none;
+ background: none;
+}
+
+#site-generator {
+ background: url("img/mozilla-logo.png") #33559B no-repeat;
+/* background: url("img/mctlogo.png") #33559B no-repeat;*/
+}
+
+#main .widget {
+ background: white;
+ border-radius: 10px;
+ padding: 20px;
+ border: #d7d9e8 solid 1px;
+ box-shadow: inset 0 -3px 3px #cde6f5;
+}
+
+.left-sidebar #content {
+ width: 67%;
+}
+#content hr {
+/* background-image: url(http://mozcom-cdn.mozilla.net/img/covehead/divider-main.jpg); */
+ background-image: url("img/divider-main.jpg");
+ background-color: white;
+ background-position: top center;
+ margin: 0;
+ padding-bottom: 1.625em;
+ min-height: 48px;
+}
+
+.left-sidebar #secondary {
+ margin-left: 4.5%;
+}
+
+.singular .hentry {
+ padding: none;
+}
+
+#site-generator a {
+ color: #669BE1;
+}
Something went wrong with that request. Please try again.