Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for type' for Buttons. #202

Merged
merged 2 commits into from Aug 26, 2016
Merged

Conversation

vipentti
Copy link
Collaborator

This allows for setting the type of the button.

    Button.render ...
      [ Button.type' "button"
      ]
      [ ... ]

@@ -112,6 +114,7 @@ type alias Config m =
{ ripple : Bool
, onClick : Maybe (Attribute m)
, disabled : Bool
, buttonType : Maybe String
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just type'?

@debois
Copy link
Owner

debois commented Aug 25, 2016

Made a few comments, but otherwise, merge at will.

Question of principle: Do we want the demo to exhibit or at least mention in text everything a component can do? Pro: It'd be great for users. Con: It'll be a ton of work for us, making we sure we have a demo of stuff like this, or at least mention it in text.

@vipentti vipentti merged commit f868f1c into debois:v7 Aug 26, 2016
@vipentti vipentti deleted the button-type branch August 26, 2016 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants