Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run git fetch before diffing the remote repository. #186

Merged
merged 1 commit into from Feb 17, 2017

Conversation

bfabio
Copy link
Contributor

@bfabio bfabio commented Feb 17, 2017

For debops-update --dry-run to work properly, the remote needs to be
fetched beforehand.

For debops-update --dry-run to work properly, the remote needs to be
fetched beforehand.
@bfabio
Copy link
Contributor Author

bfabio commented Feb 17, 2017

It's a little bit of a stretch on what a dry run should be, but there's no way (that I'm aware of) around it.

@drybjed
Copy link
Member

drybjed commented Feb 17, 2017

Sounds like there's no way to avoid the fetch so I suppose that's OK. New commits won't be merged to existing branch.

@drybjed drybjed merged commit de03808 into debops:master Feb 17, 2017
@ypid
Copy link
Member

ypid commented Feb 18, 2017

@bfabio Note that the current implementation of reviewing could be exploited by our git hosting service (currently GitHub) as you do a fetch two times and the later one is used. Just something to note. It would be nice to see a more robust update mechanism implemented, one which is also tried with the debops-keyring (ref #164).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants