[pki] Fix missing quotes causing invalid directory creation

(cherry picked from commit f72d17c)
debops · Apr 3, 2023 · 631dadf · 631dadf
1 parent 2553f74
commit 631dadf
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -154,6 +154,9 @@ General
   correctly. After that re-run the :ref:`debops.pki` role on the host to
   re-create che realms.
 
+- Path of the Root CA directory on the Ansible Controller is quoted in the
+  :file:`pki-authority` script to prevent wrong directory creation.
+
 :ref:`debops.preseed` role
 ''''''''''''''''''''''''''
 

diff --git a/ansible/roles/pki/files/secret/pki/lib/pki-authority b/ansible/roles/pki/files/secret/pki/lib/pki-authority
@@ -231,7 +231,7 @@ initialize_environment () {
     config["private_file_mode"]="600"
 
     # shellcheck disable=SC2174
-    test -d ${config['pki_root']} || mkdir -p -m ${config['public_dir_mode']} ${config['pki_root']}
+    test -d "${config['pki_root']}" || mkdir -p -m ${config['public_dir_mode']} "${config['pki_root']}"
 }
 
 enter_authority () {