[gitlab_runner] Fix compatible with GitLab 17.0 or higher #2497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since GitLab 17.0 API server returns
410 Gonestatus for the/api/v4/runnersendpoint. Because the registration token has been deprecated and will be removed on GitLab 18.0.The PR changes the runner registration using new API - create a runner linked to a user.
According to GitLab documentation, this should be compatible with GitLab 15.10 or higher.
The new API requires a personal access token, so the
gitlab_runner__api_tokenparameter becomes mandatory.Second commit
Removed the task to check GitLab API availability. This guard is useless in cases when the endpoint is overridden in the instance parameters (
api_url).