Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepend the Pepys path to the PATH variable, rather than appending it #1108

Merged
merged 2 commits into from
Dec 8, 2021

Conversation

robintw
Copy link
Collaborator

@robintw robintw commented Dec 8, 2021

🧰 Issue

Fixes #1107.

🚀 Overview:

Changes the installation script to prepend the Pepys path to the PATH environment variable, so it takes priority over other entries on the path.

🤔 Reason:

So the correct version of Pepys is used.

🔨Work carried out:

  • Modify install pepys script
  • Tests pass

Confirmations

  • I have chosen reviewers for my PR.
  • I have chosen an appropriate label for the PR, adding interactive_review if reviewers will need to see UI
  • I have extended/updated the documentation in \docs folder
  • Any database content changes (Create, Edit, Delete) are recorded in the Log/Changes tables
  • Any database schema changes are implemented via alembic revision transitions
  • I have completed the mandatory sections of this document.
  • I have deleted any unused sections.

@IanMayo IanMayo temporarily deployed to pepys-timeli-prepend-pe-xwn1fj December 8, 2021 12:55 Inactive
@robintw
Copy link
Collaborator Author

robintw commented Dec 8, 2021

In this PR I've done a 'quick fix' that prepends the Pepys path rather than appends it. It might be possible to look for other possible Pepys paths and remove those, but that's going to be a little tricky and take a while - and I'm not sure whether it's actually the best idea. We can discuss that going forward, but for now this should at least get things working.

@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #1108 (1c7bc51) into develop (4b1954b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1108   +/-   ##
========================================
  Coverage    80.08%   80.08%           
========================================
  Files          110      110           
  Lines        11896    11896           
========================================
  Hits          9527     9527           
  Misses        2369     2369           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55e9bbe...1c7bc51. Read the comment docs.

@IanMayo IanMayo temporarily deployed to pepys-timeli-prepend-pe-xwn1fj December 8, 2021 14:40 Inactive
@IanMayo IanMayo merged commit 534117f into develop Dec 8, 2021
@IanMayo IanMayo deleted the prepend-pepys-to-path branch December 8, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with installing Pepys on multiple occasions
2 participants