tilp: Use g_get_user_config_dir() to get the config directory #75
Conversation
This allows the XDG base specification to be followed, defaulting to LocalAppData on windows
tilp/trunk/help/chapter07.html
Outdated
| values: | ||
| This section describes the format of the tilp.ini config file which is | ||
| in the configuration directory of the user ($XDG_CONFIG_HOME or | ||
| LocalAppData on windows). The file is separated into several sections |
There was a problem hiding this comment.
After merging the PR, a bit later, I'll fix "windows" to "Windows", and add a note about the automatic upgrade from the config file at the old location. Unless you beat me to rewriting the commit :)
|
With backwards compatibility handled, that looks entirely reasonable. Just one nitpick about the documentation. |
(also fixes 'windows' -> 'Windows')
|
@debrouxl any update on this PR? |
|
Not really, I still haven't tested it on my side... sorry. |
|
@debrouxl thats alright, I just wanted to make sure there was nothing more on my side to be done |
|
Patch applied locally, which is a start :) |
|
@debrouxl have you had the chance to continue testing? |
|
I can probably check on macOS too I suppose. |
|
Looks like it's half OK for me here on mac OS as there's still something weird. Before your PR, So far, so good. The weird thing is that with your PR, it thinks the "old path" is
|
the dot was accidentally removed while copying. The leading dot has been re-added now
|
Right. Looks good! |
|
@debrouxl with that unix issue handled, have you had a chance to get this running and tested? |
This allows the XDG base specification to be followed, defaulting to LocalAppData on windows.
It also deprecates the old config path, using the same logic as the Windows deprecated config (which has been extracted to a helper).