Improve foundations to start implement specific features #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add appbar component while removing cra scaffold specific files
…ide Material Design drawer comp
…g able to fetch user data from Discourse * Add base for Session scope * Add logic to SessionService to getUser and use new DiscourseService to fetch Discourse data * Remove code related to token refresh from SessionService and ensure DiscourseService will handle it instead * Change hardcoded reference of local discourse endpoint to localhost
…better cross browser support
…ra from CRA to a CRA dedicated
…ow and custom rules
…port sorting warning from eslin
…ype to avoid flow errors on com
We will have a command to format the whole project and automatically take care of only staged changes, in order to avoid large diff on PRs without need.
…of function composition
…nsistency on how inject styles
orlando
suggested changes
Mar 11, 2019
.prettierrc
Outdated
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "trailingComma": "es5", | |||
| "jsxSingleQuote": true | |||
There was a problem hiding this comment.
@duranmla I think we should use prettier's defaults instead.
|
@duranmla looks good, just a comment about prettier. I like the empty tests to be filled when we connect to the services. I would love to have docz deployed to github pages. Looks like it's possible doczjs/docz#25. I'll create a ticket for that |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having in place a plan to implement this component, this PR layout the minimal amount of scopes needed to render a basic header.
NOTE: In upcoming components, we should aim to have a clear path to develop them using issues to avoid massive PRs like this one and growth progressively through a set plan
Closes #10
Closes #8
Media
NOTE: to see all the components in their different states check project documentation
yarn docz devAggregated work