Fix APT comment syntax for older APT versions (instead of just not configuring them) #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(This one is mostly indentation changes, so definitely easier to look at via https://github.com/debuerreotype/debuerreotype/pull/59/files?w=1) |
…nfiguring them) It turns out that support for `apt.conf` comments of the style `# xxx` was added in 0.7.22 (https://salsa.debian.org/apt-team/apt/commit/81e9789b12374073e848c73c79e235f82c14df44), and that I was incorrect in simply assuming that these configuration options were making this script blow up on really old APT versions! This adds (and uses) a script that will rewrite `# ...` to `// ...` for APT versions that are old enough to need it. I've tested it successfully as far back as Debian Potato!
tianon
force-pushed
the
fix-apt-conf-comments
branch
from
64d63e0
to
10cdfdd
Compare
tianon
commented
Apr 11, 2019
| - SUITE=eol CODENAME=etch TIMESTAMP=2017-01-01T00:00:00Z SHA256=7f4914c6b46782741dd69cebba2072388693613f87748e3b6b527ece264fdf4a | ||
| - SUITE=eol CODENAME=woody ARCH=i386 TIMESTAMP=2017-01-01T00:00:00Z SHA256=562f93014c37d00fb49d49f866ef63012048ccd7b9ef6df3cb692dfc59d5d105 | ||
| - SUITE=eol CODENAME=etch TIMESTAMP=2017-01-01T00:00:00Z SHA256=eb005e297101b8e4555a08e96395fa0575cbdddf4901a081948b17a4039939bd | ||
| - SUITE=eol CODENAME=woody ARCH=i386 TIMESTAMP=2017-01-01T00:00:00Z SHA256=46a1330121271abd01e107a886b7f85ce72edb0ae9fdf9c139562dc0fba806b1 |
There was a problem hiding this comment.
These changed because they now get the apt.conf files! 💪
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that support for
apt.confcomments of the style# xxxwas added in 0.7.22 (https://salsa.debian.org/apt-team/apt/commit/81e9789b12374073e848c73c79e235f82c14df44), and that I was incorrect in simply assuming that these configuration options were making this script blow up on really old APT versions!This adds (and uses) a script that will rewrite
# ...to// ...for APT versions that are old enough to need it. I've tested it successfully as far back as Debian Potato!