Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't remove node_modules in clean target #162

Closed
ensonic opened this issue Dec 9, 2014 · 1 comment · Fixed by #189
Closed

don't remove node_modules in clean target #162

ensonic opened this issue Dec 9, 2014 · 1 comment · Fixed by #189

Comments

@ensonic
Copy link

ensonic commented Dec 9, 2014

One way to do cross compilation of nodejs apps is to "make clean" across the tree, zip up the sources and run nmp rebuild for the target. This assumes that "make clean" would leave the npm tree intact.

You should be able to use "npm install --force" to reinstall, right?
@TooTallNate
Copy link
Contributor

We can move removing node_modules to a distclean rule. I'd be ok with that.

@stephenmathieson stephenmathieson mentioned this issue Mar 26, 2015
Merged
TooTallNate added a commit that referenced this issue Mar 26, 2015
@TooTallNate
Merge pull request #189 from stephenmathieson/fix/gh-162
9feaf47 
Makefile: add a `distclean` target
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Makefile: add a distclean target
2 participants
@TooTallNate @ensonic