Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: disable() returns string of previously-enabled namespaces #523

Closed
gynnantonix opened this issue Nov 20, 2017 · 1 comment
Closed

Feature: disable() returns string of previously-enabled namespaces #523

gynnantonix opened this issue Nov 20, 2017 · 1 comment
Labels
feature This proposes or provides a feature or enhancement help-wanted This issue has an actionable item pr-welcome This issue has an approved change; a pull request would be appreciated

Comments

@gynnantonix
Copy link

So that debugging can be turned off and turned back on without needing to know what was turned on, it would be useful to have disable() return a string containing the list of namespaces that were enabled prior to the disable() call. The string should be suitable for passing to enable().
@Qix- Qix- added the feature This proposes or provides a feature or enhancement label Jun 20, 2018
@Qix-
Copy link
Member

Qix- commented Jun 20, 2018

Sure, this would be useful.

@Qix- Qix- added help-wanted This issue has an actionable item pr-welcome This issue has an approved change; a pull request would be appreciated labels Jun 20, 2018
mblarsen added a commit to mblarsen/debug that referenced this issue Oct 4, 2018
@mblarsen
feat: Return namespaces string when invoking disable()
b828357 
Closes debug-js#523
@mblarsen mblarsen mentioned this issue Oct 4, 2018
Merged
mblarsen added a commit to mblarsen/debug that referenced this issue Oct 4, 2018
@mblarsen
feat: Return namespaces string when invoking disable()
ac5a726 
Closes debug-js#523

feat: Add unit tests for disable return value
mblarsen added a commit to mblarsen/debug that referenced this issue Oct 5, 2018
@mblarsen
feat: Return namespaces string when invoking disable()
1844758 
Closes debug-js#523

feat: Add unit tests for disable return value

fix: Correct spelling in test case description
mblarsen added a commit to mblarsen/debug that referenced this issue Oct 5, 2018
@mblarsen
feat: Return namespaces string when invoking disable()
99765cc 
Closes debug-js#523

feat: Add unit tests for disable return value

fix: Correct spelling in test case description

feat: Test that disable-string works with enable again
mblarsen added a commit to mblarsen/debug that referenced this issue Oct 5, 2018
@mblarsen
feat: Return namespaces string when invoking disable()
692b107 
feat: Add unit tests for disable return value

fix: Correct spelling in test case description

feat: Test that disable-string works with enable again

Closes debug-js#523

docs: Add section about disable return value
@Qix- Qix- closed this as completed in #624 Oct 8, 2018
Qix- pushed a commit that referenced this issue Oct 8, 2018
@mblarsen @Qix-
feat: Return namespaces string when invoking disable()
7ef8b41 
feat: Add unit tests for disable return value

fix: Correct spelling in test case description

feat: Test that disable-string works with enable again

Closes #523

docs: Add section about disable return value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature This proposes or provides a feature or enhancement help-wanted This issue has an actionable item pr-welcome This issue has an approved change; a pull request would be appreciated
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Qix- @gynnantonix