Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix debug.disable() #151

Closed
wants to merge 1 commit into from
Closed

Fix debug.disable() #151

wants to merge 1 commit into from

Conversation

swook
Copy link

@swook swook commented Oct 25, 2014

Addresses issue #150

exports.disable() now resets the array exports.names to actually disable future debug instances.

@TooTallNate
Copy link
Contributor

I'd rather fix it in the enable() function. Also you're forgetting the skips array.

@swook
Copy link
Author

swook commented Oct 28, 2014

"Enable none" does not feel like the equivalent to "disable all" in my opinion.

I didn't include skips because it does affect the purpose of making debug() return an empty function.

Perhaps a reset() function would be better suited for resetting both names and skips.

@thebigredgeek thebigredgeek added change-minor This proposes or provides a change that requires a minor release discussion This issue is requesting comments and discussion feature This proposes or provides a feature or enhancement labels Nov 14, 2016
@thebigredgeek
Copy link
Contributor

@TooTallNate @swook we should probably figure out the best way to move forward on this. Do we want to extend the API or handle the skips reset in one of the existing functions?

@thebigredgeek thebigredgeek added this to the 2.4.0 milestone Nov 14, 2016
@thebigredgeek
Copy link
Contributor

@swook would love to get this merged by tonight so I can release tomorrow with 2.4.0

@swook
Copy link
Author

swook commented Nov 15, 2016

My opinion on this matter has not changed since my last comment.

Please refer to #150 for other comments.

@thebigredgeek thebigredgeek modified the milestones: 2.5.0, 2.4.0 Dec 14, 2016
@thebigredgeek
Copy link
Contributor

closing this as it doesn't sound like there is alignment on direction :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change-minor This proposes or provides a change that requires a minor release discussion This issue is requesting comments and discussion feature This proposes or provides a feature or enhancement
Development

Successfully merging this pull request may close these issues.

None yet

3 participants