Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow colours in workers #335

Merged
merged 1 commit into from
Dec 12, 2016
Merged

Conversation

botverse
Copy link
Contributor

  1. there are no window or document globals in workers, so useColors throws.
  2. there is still an opportunity to check if we are in webkit using the userAgent

@thebigredgeek
Copy link
Contributor

I am hesitant to merge something like this in without tests. We've already had a lot of issues with workers. Thoughts @TooTallNate ?

@xuset
Copy link

xuset commented Dec 10, 2016

Hi all! I've been having the same problem with require('debug') in web workers. I tried out @botverse's fix in chrome and firefox, and everything works as expected in web workers and normal contexts. Is there anything I can help with in getting this merged in?

@thebigredgeek
Copy link
Contributor

I am going to merge this, but it will be a minor semver. I will release 2.4.0 tomorrow morning with this.

@thebigredgeek thebigredgeek merged commit bd9faa1 into debug-js:master Dec 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants