Use same color for same namespace.

[lchenay]

CF #258

[TooTallNate]

is this algorithm for somewhere that we need to give credit for?

[lchenay]

Hard to find who to credit: https://www.google.com/search?q=%22Convert+to+32bit+integer%22

[TooTallNate]

http://stackoverflow.com/a/7616484/376773

[TooTallNate]

Nice and simple, thanks for the PR! I'm 👍 for this feature. There's been plenty of times where the order of require calls changing ends up changing the colors of the debug instances, since they get instantiated in a different order which has always felt strange.

The only thing I'd be worried about is if the algorithm doesn't "distribute" the colors evenly enough. But I guess we'll just have to feel it out and see.

[lchenay]

I agree, it will have less perfect distribution on colors over namespace.
To reduce chance of collision, as it's no more incremental, the only solution is to have more colors available.

[Meithar]

This algorithm doesn't seem to work well. Example:

console.log({
  namespace,
  hash: Math.abs(hash),
  color: exports.colors[Math.abs(hash) % exports.colors.length],
});

{namespace: "rto-ext:EVENTS", hash: 1808327694, color: "lightseagreen"}
{namespace: "rto-ext:SETTINGS", hash: 1479630660, color: "lightseagreen"}
{namespace: "rto-ext:BG", hash: 33268638, color: "lightseagreen"}

Three different namespaces have the same color.

[lchenay]

exports.colors.length == 6
So 16% of chance of collision.

@TooTallNate More color ?

Otherwise we need to have an array to store the colors stickiness. Not as complicated as this.

[lchenay]

We can try something like that otherwise : lchenay@9f4404f

The color will be better distributed as before, with reuse of same color for same namespace, but will use some memory to store the array of mapping.
This can lead to memory leak if a user use debug in prod with random namespace. For exemple those who use a namespace like "myapp:request:${request.expressRequestId}".