Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

caching enabled status per logger #799

Merged
merged 2 commits into from Dec 9, 2020
Merged

caching enabled status per logger #799

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0f645e
caching enabled status per logger
containmentbreach Dec 3, 2020
2c6f610
Apply suggestions from code review
containmentbreach Dec 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/common.js
View file
Open in desktop
Expand Up @@ -60,6 +60,7 @@ function setup(env) {
function createDebug(namespace) {
let prevTime;
let enableOverride = null;
let namespacesCache, enabledCache;
containmentbreach marked this conversation as resolved.
Show resolved Hide resolved

function debug(...args) {
// Disabled?
Expand Down Expand Up @@ -120,7 +121,17 @@ function setup(env) {
Object.defineProperty(debug, 'enabled', {
enumerable: true,
configurable: false,
get: () => enableOverride === null ? createDebug.enabled(namespace) : enableOverride,
get: () => {
if (enableOverride !== null) {
return enableOverride
containmentbreach marked this conversation as resolved.
Show resolved Hide resolved
}
if (namespacesCache !== createDebug.namespaces) {
namespacesCache = createDebug.namespaces;
enabledCache = createDebug.enabled(namespace);
}
return enabledCache;

containmentbreach marked this conversation as resolved.
Show resolved Hide resolved
},
set: v => {
enableOverride = v;
}
Expand Down Expand Up @@ -149,6 +160,7 @@ function setup(env) {
*/
function enable(namespaces) {
createDebug.save(namespaces);
createDebug.namespaces = namespaces;

createDebug.names = [];
createDebug.skips = [];
Expand Down