#937 Mulit-Tag sorting feature #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
42ama
commented
Apr 25, 2024
42ama
commented
- Added new Column property - contentsSortDir, it stores information about sorting the content in the cells of the column. At the moment the only type that can store several items in a cell is MultiTag, so the processing logic was added only for it.
- Added a options submenu for columns with MultiTag type, where you can select the sorting type for the cell contents.
+ Added new Column property - contentsSortDir, it stores information about sorting the content in the cells of the column. At the moment the only type that can store several items in a cell is MultiTag, so the processing logic was added only for it. + Added a options submenu for columns with MultiTag type, where you can select the sorting type for the cell contents.
|
@trey-wallis hello! Checkout this pull-request for #937 please |
|
@42ama Looking good. Thanks for the contribution. I have just 2 suggestions: |
|
@trey-wallis renamed both |
|
Thanks |
decaf-dev
added a commit
that referenced
this pull request
Apr 28, 2024
* #937 Mulit-Tag sorting feature (#944) * #937 Mulit-Tag sorting feature + Added new Column property - contentsSortDir, it stores information about sorting the content in the cells of the column. At the moment the only type that can store several items in a cell is MultiTag, so the processing logic was added only for it. + Added a options submenu for columns with MultiTag type, where you can select the sorting type for the cell contents. * Renamed `contentsSortDir` to `multiTagSortDir` and `Contents sorting` to `Sort` * feat: add display name for sort direction * fix: don't close menu on sort select * build: fix build errors * chore: bump to 8.16.0 --------- Co-authored-by: Maxim <45532431+42ama@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.