Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Travis CI with GitHub Actions #157

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Nov 23, 2023

Fixes #156.

Travis CI has stopped working, so replace with GitHub Actions.

GHA is preferable over AppVeyor as they provide max 20 concurrent jobs compared to AppVeyor's one, so the build completes much faster.

Only added testing for supported versions, 3.8-3.12:

image

We can add 3.7 I think, but at least 2.7 and 3.6 are no longer available for testing, and I strongly suggest dropping support for them in another issue/PR.

Also add a tox.ini for easy testing of multiple Python versions locally.

I also replaced coveralls with codecov, because I've had difficulty setting up coveralls on GitHub Actions in the past, and there's been no updates to https://coveralls.io/github/decalage2/olefile?branch=master since 2017.

Demo

@decalage2 decalage2 self-requested a review November 23, 2023 15:38
@decalage2 decalage2 added enhancement tests related to testing and continuous integration labels Nov 23, 2023
@decalage2 decalage2 added this to the olefile 0.47 milestone Nov 23, 2023
@decalage2
Copy link
Owner

Hi Hugo, thank you so much for your contributions on this!
Do you think it would be possible to keep AppVeyor in addition, just to run tests on python 2.7 and pypy2?

@hugovk
Copy link
Contributor Author

hugovk commented Nov 24, 2023

You're welcome!

Sure, I updated .coveragerc to keep exclude_lines so it still works on ancient Python versions on AppVeyor.

Copy link
Owner

@decalage2 decalage2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@decalage2 decalage2 merged commit 421c450 into decalage2:master Nov 30, 2023
1 check passed
@hugovk hugovk deleted the add-github-actions branch November 30, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement tests related to testing and continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: remove Travis-CI, extend AppVeyor config
2 participants