Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop testing and official support for EOL Python 3.3 #85

Merged
merged 1 commit into from
Jan 4, 2018
Merged

Drop testing and official support for EOL Python 3.3 #85

merged 1 commit into from
Jan 4, 2018

Conversation

jdufresne
Copy link
Contributor

Python 3.3 is end of life. It is no longer receiving bug fixes,
including for security issues. It has been EOL since 2017-09-29.

https://devguide.python.org/#status-of-python-branches

@coveralls
Copy link

coveralls commented Jan 4, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 65.298% when pulling 77c3f9b on jdufresne:py33 into a75f539 on decalage2:master.

@coveralls
Copy link

coveralls commented Jan 4, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 65.298% when pulling 16113d5 on jdufresne:py33 into a75f539 on decalage2:master.

hugovk
hugovk approved these changes Jan 4, 2018
View reviewed changes
Copy link
Contributor

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding python_requires to setup?

@hugovk
Copy link
Contributor

hugovk commented Jan 4, 2018 •
edited
Loading

The new Pillow 5.0.0 has just dropped Python 3.3 so no longer depends on olefile supporting it.

I don't know if you're following semver, but that usually warrants a major version bump. And after eight years, I think olefile definitely deserves a 1.0 release by now :)

@jdufresne
Drop testing and official support for EOL Python 3.3
e948985 
Python 3.3 is end of life. It is no longer receiving bug fixes,
including for security issues. It has been EOL since 2017-09-29.

https://devguide.python.org/#status-of-python-branches
@jdufresne
Copy link
Contributor Author

How about adding python_requires to setup?

Good call! Done in the latest revision.

@coveralls
Copy link

coveralls commented Jan 4, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 65.298% when pulling e948985 on jdufresne:py33 into a75f539 on decalage2:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 65.298% when pulling e948985 on jdufresne:py33 into a75f539 on decalage2:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 65.298% when pulling e948985 on jdufresne:py33 into a75f539 on decalage2:master.

@decalage2 decalage2 added this to the olefile 0.45 milestone Jan 4, 2018
@decalage2 decalage2 merged commit e543498 into decalage2:master Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

@decalage2 decalage2 decalage2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
olefile 0.45
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jdufresne @coveralls @hugovk @decalage2