Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oleobj.py BLACKLISTED_RELATIONSHIP_TYPES list of items are not correctly/syntactically separated with comma(,) #641

Closed
ghanashyams opened this issue Nov 6, 2020 · 1 comment · Fixed by #670
Assignees
Milestone

Comments

@ghanashyams
Copy link

Affected tool:
oleobj

Describe the bug
Seems syntax bug in BLACKLISTED_RELATIONSHIP_TYPES list of items. 'externalReference' and
'frame' are not comma(,) separated.

File/Malware sample to reproduce the bug
BLACKLISTED_RELATIONSHIP_TYPES = [
'attachedTemplate',
'externalLink',
'externalLinkPath',
'externalReference'
'frame'
'hyperlink',
'officeDocument',
'oleObject',
'package',
'slideUpdateUrl',
'slideMaster',
'slide',
'slideUpdateInfo',
'subDocument',
'worksheet'
]

How To Reproduce the bug
Seems syntax bug in BLACKLISTED_RELATIONSHIP_TYPES list of items. 'externalReference' and
'frame' are not comma(,) separated.

Expected behavior
Seems syntax bug in BLACKLISTED_RELATIONSHIP_TYPES list of items. 'externalReference' and
'frame' are not comma(,) separated.
Console output / Screenshots
If applicable, add screenshots to help explain your problem.
Use the option "-l debug" to add debugging information, if possible.

Version information:

  • OS: Windows/Linux/Mac/Other
  • OS version: x.xx - 32/64 bits
  • Python version: 2.7/3.6 - 32/64 bits
  • oletools version: .56

Additional context
Add any other context about the problem here.

@decalage2 decalage2 self-assigned this Nov 6, 2020
@decalage2 decalage2 added this to the oletools 0.56 milestone Nov 6, 2020
decalage2 added a commit that referenced this issue Mar 29, 2021
oleobj: Missing commas in BLACKLISTED_RELATIONSHIP_TYPES
@decalage2
Copy link
Owner

Fixed by PR #670.

@decalage2 decalage2 linked a pull request Mar 29, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants