Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

olevba: fix sys.argv[1] using xlmdeobfuscator #737

Merged
merged 1 commit into from
Feb 6, 2022

Conversation

minanokawari1124
Copy link

When I parse xlm macro from external software using olevba, I found a bug in the following line.

oletools/oletools/olevba.py

Lines 3424 to 3430 in 412ee36

result = xlmdeobfuscator.process_file(file=sys.argv[1],
noninteractive=True,
noindent=True,
# output_formula_format='CELL:[[CELL_ADDR]], [[INT-FORMULA]]',
return_deobfuscated=True,
timeout=30,
)

In order to make it available from external software, I changed the call to be the same as line 3409:

result = xlmdeobfuscator.process_file(file=self.filename,

@decalage2 decalage2 self-assigned this Feb 6, 2022
@decalage2 decalage2 added this to the oletools 0.60 milestone Feb 6, 2022
@decalage2 decalage2 merged commit 45a528a into decalage2:master Feb 6, 2022
@decalage2
Copy link
Owner

Thanks a lot for spotting this bug!

decalage2 added a commit that referenced this pull request Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants