Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship source code to NPM #1095

Merged
merged 3 commits into from
Mar 28, 2018
Merged

Ship source code to NPM #1095

merged 3 commits into from
Mar 28, 2018

Conversation

tech4him1
Copy link
Contributor

- Summary

Closes #553. This PR changes the npm publish command to package our source code as well. Source maps now reference independent files rather than a single bundle.

- Test plan

Manually tested that sourcemaps still work.

- Description for the changelog

Ship source code to NPM.

- A picture of a cute animal (not mandatory but encouraged)

@tech4him1 tech4him1 changed the title Ship source code to NPM. Ship source code to NPM Feb 9, 2018
@verythorough
Copy link
Contributor

verythorough commented Feb 9, 2018

Deploy preview for netlify-cms-www ready!

Built with commit cefda08

https://deploy-preview-1095--netlify-cms-www.netlify.com

@verythorough
Copy link
Contributor

verythorough commented Feb 9, 2018

Deploy preview for cms-demo ready!

Built with commit cefda08

https://deploy-preview-1095--cms-demo.netlify.com

Copy link
Contributor

@erquhart erquhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tech4him1
Copy link
Contributor Author

This can be merged as soon as it gets a review.

@erquhart erquhart merged commit 7df903c into master Mar 28, 2018
@erquhart erquhart deleted the small-src-maps branch March 28, 2018 15:13
brianlmacdonald pushed a commit to brianlmacdonald/netlify-cms that referenced this pull request May 23, 2018
* Ship sources in NPM package.

* Use external source files for sourcemaps.

* Remove broken sourcemap rule.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ship source code with npm package
3 participants