Add markdown editor toolbar customization #1236
Conversation
|
Deploy preview for cms-demo ready! Built with commit 73630a4 |
|
Deploy preview for netlify-cms-www ready! Built with commit 73630a4 |
| const { | ||
| onMarkClick, | ||
| onBlockClick, | ||
| onLinkClick, | ||
| selectionHasMark, | ||
| selectionHasBlock, | ||
| selectionHasLink, | ||
| disabled, |
There was a problem hiding this comment.
We could minimize changes to this file by simply adding a hidden prop to ToolbarButton. What do you think?
There was a problem hiding this comment.
And if the the hidden property is true, the render function simply return null ?
There was a problem hiding this comment.
Yep. I'd usually avoid components managing their own visibility, but in this case it feels worth the trade off.
| @@ -14,6 +14,7 @@ The markdown widget provides a full fledged text editor - which is based on [sla | |||
| - **Data type:** markdown | |||
| - **Options:** | |||
| - `default`: accepts markdown content | |||
| - `buttons`: a list of string representing the buttons to display ('bold', 'italic', 'code', 'link', 'heading-one', 'heading-two', 'quote', 'code', 'bulleted-list', 'numbered-list'). If this options is missing, all the buttons are display. | |||
There was a problem hiding this comment.
Update to:
buttons: an array of strings representing the formatting buttons to display, all buttons shown by default. Buttons include: "bold", "italic", "code", "link", "heading-one", "heading-two", "quote", "code-block", "bulleted-list", and "numbered-list".
While we happen to be using the types from our code, we shouldn't rely on this option aligning with type names. Note that I changed the second "code" to "code-block".
|
@erquhart I added the |
|
Awesome! Can you update the docs snippet to this edited version:
|
|
@erquhart documentation updated |
Add markdown editor toolbar customization #1194
- Summary
Closes #1194
Add markdown toolbar buttons customization, based on conf file :
- Test plan
If no
buttonsfield is specified we display all the buttons otherwise we display the list.- Description for the changelog
Add markdown editor toolbar customization