Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix the umd builds #2214

Merged
merged 4 commits into from Mar 18, 2019
Merged

fix: Fix the umd builds #2214

merged 4 commits into from Mar 18, 2019

Conversation

talves
Copy link
Collaborator

@talves talves commented Mar 17, 2019

Summary

  • One fix to import the backends correctly
  • Fixes for a caps issue with the Redux folder name cases vs alias vs module import (alias added to resolve)
  • Fix the localForage folder case vs alias vs module import (alias added to resolve)
  • Fix a path import issue from '.' to './index'

Test plan

Same tests as original PR #2141

A picture of a cute animal (not mandatory but encouraged)
馃悽

Removes the module issue for windows same case due to alias resolution.
This has caused some issues in resolving the path. Best practices. Needs a lint. 馃榾
@netlify
Copy link

netlify bot commented Mar 17, 2019

Preview proposed changes to the CMS demo site in the link below:

Built with commit d659713

https://deploy-preview-2214--cms-demo.netlify.com

@talves
Copy link
Collaborator Author

talves commented Mar 17, 2019

@erquhart I found these issues. Not all breaking, because the case issues are windows issues mostly.

I am working on an es6 bundle PR and these things showed up right away, so it was a good thing. 馃槣

@talves
Copy link
Collaborator Author

talves commented Mar 17, 2019

@erquhart I keep forgetting to ask you if you want me to return those export names back for the backends or follow the same export names as the widgets, so we are ready for them to also have a register name as 'controlComponent'. Although they are not really components as much as control class modules.

@erquhart
Copy link
Contributor

Oh yeah, I meant to content on that in the original pull requests, the nomenclature should be changed to be specific to backends as "control" doesn't really apply there.

Awesome to hear you're working on ES6 modules!!!

Sent with GitHawk

@talves
Copy link
Collaborator Author

talves commented Mar 18, 2019

Ok, no problem. I wonder if they should follow a common for export like the widgets, so we can make the API the same way?

I will do it first thing in the am. completed.

Copy link
Contributor

@erquhart erquhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @talves!

@erquhart erquhart merged commit e04f6be into decaporg:master Mar 18, 2019
@netlify
Copy link

netlify bot commented Mar 19, 2019

Preview proposed changes to netlifycms.org in the link below:

Built with commit d659713

https://deploy-preview-2214--netlify-cms-www.netlify.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants