Feat: Align GitHub metadata handling with other backends #3316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
commented
Feb 24, 2020
| const mapped = pullRequests.nodes.map(transformPullRequest); | ||
|
|
||
| return ((mapped as unknown) as Octokit.PullsListResponseItem[]).filter( | ||
| pr => pr.head.ref.startsWith(`${CMS_BRANCH_PREFIX}/`) && predicate(pr), |
There was a problem hiding this comment.
Same as REST API
erezrokah
commented
Feb 24, 2020
| @@ -355,7 +368,7 @@ export default class API { | |||
| const changeTree = await this.updateTree(branchData.sha, [file as TreeFile]); | |||
| const { sha } = await this.commit(`Updating “${key}” metadata`, changeTree); | |||
| await this.patchRef('meta', '_netlify_cms', sha); | |||
| localForage.setItem(`gh.meta.${key}`, { | |||
| await localForage.setItem(`gh.meta.${key}`, { | |||
There was a problem hiding this comment.
This was a long standing bug causing caching issues that surfaced in the tests
erezrokah
commented
Feb 24, 2020
| @@ -41,7 +41,7 @@ export const readFile = async ( | |||
|
|
|||
| const content = await fetchContent(); | |||
| if (key) { | |||
| localForage.setItem(key, content); | |||
| await localForage.setItem(key, content); | |||
There was a problem hiding this comment.
Similar caching bug
erezrokah
commented
Feb 24, 2020
| ); | ||
|
|
||
| return pullRequests.filter( | ||
| pr => pr.head.ref.startsWith(`${CMS_BRANCH_PREFIX}/`) && predicate(pr), |
There was a problem hiding this comment.
@erquhart pr.head.ref.startsWith(`${CMS_BRANCH_PREFIX}/`) was missing from the previous PR.
|
Looking into why the test is passing locally on my machine and not on CI |
2 tasks
erquhart
approved these changes
Feb 24, 2020
vladdu
pushed a commit
to vladdu/netlify-cms
that referenced
this pull request
Jan 26, 2021
…org#3316) * Revert "Revert "feat(core): Align GitHub metadata handling with other backends (decaporg#3292)"" This reverts commit 5bdd3df. * fix(backend-github): fix migration code * test(backend-github): fix test * test(e2e): shorten wait time * test(e2e): try and fix test on CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #3292
Fixes #1669
Fixes #3303
This time with a fix to the migration code.
Added a test to migrate from
2.9.7to current and2.10.24to current.The test: