Prevent long code lines from breaking visual entry editor #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, long lines of preformatted text would cause the lines to run off the side of the ProseMirror edit box and give the entire entry editor a scrollbar. This commit makes the edit box itself scroll, which looks and feels much less broken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Previously, long lines of preformatted text would cause the lines to run off the side of the ProseMirror edit box and give the entire entry editor a horizontal scrollbar. This commit makes the edit box itself scroll, which looks and feels much less broken.
- Test plan
Tested manually (no visual diff testing exists on this project at the moment).
- Description for the changelog
Prevent long code lines from breaking visual entry editor.