Relation preview improvements #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erquhart
commented
Jun 30, 2017
| Param | Type | Description | ||
| --- | --- | --- | ||
| `name` | string | Widget name, allows this widget to be used via the field `widget` property in config | ||
| `control` | React.Component \| string | <ul><li>React component that renders the control, receives the following props: <ul><li>**value:** Current field value</li><li>**onChange**: Callback function to update the field value</li></ul></li><li>Name of a registered widget whose control should be used (includes built in widgets).</li></ul> |
There was a problem hiding this comment.
Yes, all of this nested list markup is horrible. I am very ashamed.
There was a problem hiding this comment.
It's better than nothing! And it does render fairly well. Tables are the worst thing about markdown. 😛
Benaiah
force-pushed
the
relation-preview-improvements
branch
from
746930b
to
9fdc458
Compare
erquhart
force-pushed
the
relation-preview-improvements
branch
from
9fdc458
to
6af9a31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
This PR addresses three problems:
- Description for the changelog
Allow custom widgets to reuse existing widget controls
- A picture of a cute animal (not mandatory but encouraged)
